Fix browser tooltip refresh for table comments #64441
Conversation
- Update QgsDataItem::refresh() to copy tooltips from new items to existing items - Add RefreshChildrenWhenItemIsRefreshed capability to PostgreSQL and HANA schema items - Enables proper refresh of table comments at both connection and schema levels
|
This is not quite the right approach -- you should instead update the "equals" methods for the item subclass which isn't being correctly updated to consider the tooltip too |
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🍎 MacOS Qt6 buildsDownload MacOS Qt6 builds of this PR for testing. |
|
@TimMcCauley lgtm! Can you confirm this new approach fixes the issue? |
|
Hi @nyalldawson it so far only fixes it if a user clicks refresh on the schema itself. I also want the tooltip to refresh itself after a user clicks OK in the dialog. Somehow it is not working yet, I am still working on it. |
|
Greetings @nyalldawson - this does work now. Please find video proof attached to this comment. I removed it from the HANA provider again as this does not provide setting table comments. Screencast_20260110_213435.webm |
agiudiceandrea
added
the
Bug
src/core/browser/qgsdataitem.cpp
Outdated
| if ( !mFutureWatcher ) | ||
| { | ||
| mFutureWatcher = std::make_unique<QFutureWatcher<QVector<QgsDataItem *> >>( this ); | ||
| mFutureWatcher = std::make_unique<QFutureWatcher<QVector<QgsDataItem *> >> ( this ); |
There was a problem hiding this comment.
Can you revert the unrelated formatting changes to this file?
.gitignore
Outdated
| .kdev4/ | ||
| .project | ||
| .pydevproject | ||
| .qtcreator |
There was a problem hiding this comment.
unrelated change (and duplicate of line 33)
3 participants
Description
Fixes the bug described in #64414
What now works
The comment is updated in the tooltip once the user sets a new comment.